Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP39: add license and copyright section #1680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Oct 8, 2024

These are required for legal use, and also per BIP-2, and they avoid user confusion as seen in #1395 (comment).

Choice of MIT license per BIP author feedback in #1395 (comment).

The license omission was likely an oversight.

BIP-39 predates BIP-2 by 2-3 years. BIP-1 (in force at the time, since superseded by BIP-2) did require a copyright or public domain section.

These are required per BIP-2, and they avoid user confusion as seen in

bitcoin#1395 (comment)
@jonatack
Copy link
Member Author

jonatack commented Oct 8, 2024

cc @prusnak for approval

@prusnak
Copy link
Contributor

prusnak commented Oct 8, 2024

ACK

@murchandamus
Copy link
Contributor

Concept ACK, but for a license change, I expect that we need all rights holders to agree. cc: @slush0, @ebfull, @voisine

@kanzure
Copy link
Contributor

kanzure commented Oct 8, 2024

is licensing and CLAs addressed in the new bip2 @murchandamus ?

@slush0
Copy link
Contributor

slush0 commented Oct 8, 2024

ACK MIT

@jonatack
Copy link
Member Author

Pinging @ebfull and @voisine for approval here.

@murchandamus murchandamus added the Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified label Nov 7, 2024
@murchandamus
Copy link
Contributor

is licensing and CLAs addressed in the new bip2 @murchandamus ?

Just in so far as we have always required an "acceptable license" that permitted others to use the work. My new process BIP draft so far does not propose a CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified Proposed BIP modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants