BIP373: Clarify where keys in MuSig fields may appear in the Taproot output #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bigspider |
lozanopo
approved these changes
Nov 6, 2024
jonatack
added
Proposed BIP modification
Pending acceptance
I think you meant |
bigspider
reviewed
Nov 7, 2024
|
ACK, only left a small nit to make it more explicit. |
achow101
force-pushed
the
373-clarify-plain-pub
branch
from
351aad6
to
16be6ec
Compare
Oops yes, fixed. |
jonatack
reviewed
Nov 8, 2024
- The aggregate pubkey in `PSBT_{IN,OUT}_MUSIG2_PARTICIPANT_PUBKEYS` does not have to
appear anywhere in the Taproot output.
- The plain pubkeys in `PSBT_IN_MUSIG2_PUB_NONCE` and
`PSBT_IN_MUSIG2_PARTIAL_SIG` must be either the output pubkey, or
appears in a script, and not the internal key.
achow101
force-pushed
the
373-clarify-plain-pub
branch
from
16be6ec
to
0ff32bd
Compare
jonatack
reviewed
Nov 8, 2024
jonatack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSBT_{IN,OUT}_MUSIG2_PARTICIPANT_PUBKEYSdoes not have to appear anywhere in the Taproot output.PSBT_IN_MUSIG2_PUB_NONCEandPSBT_IN_MUSIG2_PARTIAL_SIGmust be either the output pubkey, or appears in a script, and not the internal key.