Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP390: Clarify that musig cannot be used in top-level pk() or pkh() #1696

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

bigspider
Copy link
Contributor

As it is valid to use pk(musig(...)) or pkh(musig(...)) inside taproot scripts, I think the invalid examples might otherwise be misinterpreted.

@bigspider
Copy link
Contributor Author

cc @achow101

@bigspider bigspider changed the title Clarify that musig cannot be used in top-level pk() or pkh() 390: Clarify that musig cannot be used in top-level pk() or pkh() Nov 8, 2024
@achow101
Copy link
Member

achow101 commented Nov 8, 2024

ACK 2e8f6ba

@jonatack jonatack changed the title 390: Clarify that musig cannot be used in top-level pk() or pkh() BIP390: Clarify that musig cannot be used in top-level pk() or pkh() Nov 8, 2024
@jonatack jonatack merged commit 711802c into bitcoin:master Nov 8, 2024
4 checks passed
@jonatack
Copy link
Member

jonatack commented Nov 8, 2024

ACK

@bigspider bigspider deleted the bip390-nit branch November 8, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants