-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Convert Task and Lazys so they can be (de)serialized #86
base: master
Are you sure you want to change the base?
Conversation
@CableZa, I think this pull request will satisfy your requirement for recording and playing back a |
eb4746d
to
8c331c1
Compare
Awesome @blairconrad, I will check this out! |
8c331c1
to
5a8d70a
Compare
5a8d70a
to
6fb3f25
Compare
Hey, @CableZa. Any feedback? Did it work out for you? Not work out for you? |
Hey @blairconrad, sorry for taking close on a year for responding. Though this does look like it would cover what I was keen for at the time, I ended up taking a different strategy regarding testing and test doubles. Thanks so much for taking the time, I have learned a lot from looking through the code in SelfInitializingFakes, as well the response to my initial PR. Till the next time, cheers! |
Hey, @CableZa. Good to hear from you. While I'm sorry that you were never able to take advantages of the changes in this pull request, I'm very glad that you found value in the exchange. Happy OSSing. |
Fixes #81.
This solution is independent of serializers, and supports
Task
s,Tasks<T>
s, andLazy<T>
s, including any (directly) nested combinations of these, e.g.Lazy<Task<T>>
.However, these are only supported as the "top": as a direct return value, or out or ref parameter. A
List<Task<T>>
would not be handled.