Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NonlinearConjugateGradientOptimizer #1877

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Oct 15, 2024

  1. Removed templates.
  2. Removed the System class so we only need a factor graph.
  3. Formatting

Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needed a design review before making a drastic change like this. There are reasons why System exists. Please talk to me first.

@varunagrawal
Copy link
Collaborator Author

Gotcha. It just seemed strange that System was inside the optimizer rather than being passed as an argument. It made it seem like extensibility was not easy in that particular case.
Let's chat about this.

@varunagrawal
Copy link
Collaborator Author

Merging this to parent PR since this is just formatting changes.

@varunagrawal varunagrawal merged commit 5786073 into conjugate-gradient Oct 16, 2024
25 checks passed
@varunagrawal varunagrawal deleted the conjugate-gradient-system branch October 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants