-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant speedup #1881
Significant speedup #1881
Conversation
@varunagrawal Hoping to get a quick review so I can cut an alpha version of GTSAM soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments but LGTM.
Removing the conditionals duplication was on my TODO list (planned to do it after figuring out memory issues) so this is great!
Speedups across the board
In DT:
In HGC
In HGFG
Result
struct to eliminate double compute of negLogKExtra
split
: unused for now but could speed up if split could build only two trees instead of three; in that case, we could try building ResultTree as two trees instead, and one of them could be used to create the HGCs directly