Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min required cmake version to 3.9 #1899

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

jlblancoc
Copy link
Member

In the top-level cmake file. It was 3.5 and recent cmake versions complain about it becoming deprecate.
Also, the wrap directory already required 3.9 anyhow.

PS: This is only an issue to users of Ubuntu 16.04 or older...

In the top-level cmake file. It was 3.5 and recent cmake versions
complain about it becoming deprecate.
Also, the wrap directory already required 3.9 anyhow...
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of following deprecation warnings. Hopefully we don't get too many complaints from users on older systems.

@varunagrawal varunagrawal merged commit a95d816 into develop Nov 9, 2024
33 checks passed
@varunagrawal varunagrawal deleted the fix/more-gcc-warnings-ros-builds branch November 9, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants