Feat: iterable_chunk() #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpolaszek
force-pushed
the
feature/iterable-chunk
branch
from
7485baf
to
1e5f3af
Compare
|
@simPod would you have a few minutes reviewing this? Thx! |
simPod
suggested changes
Jun 2, 2024
Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
simPod
reviewed
Jun 4, 2024
| @@ -118,6 +119,16 @@ public function values(): self | |||
| return new self(new WithoutKeysTraversable($this->iterable)); | |||
| } | |||
|
|
|||
| /** @return iterable<int, array<TKey, TValue>> */ | |||
There was a problem hiding this comment.
/** @return iterable<int, iterable<TKey, TValue>> */
There was a problem hiding this comment.
shit - didn't notice on time static analysis was failing, will open another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled upon requiring the
array_chunkfunction on a generator - let's introduceiterable_chunk()!