itest: remove explicit hop hint inclusion

breez · Jun 17, 2024 · 7001ef4 · 7001ef4
1 parent d688f37
commit 7001ef4
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 17 deletions.
diff --git a/itest/lntest/cln_node.go b/itest/lntest/cln_node.go
@@ -511,10 +511,6 @@ func (n *ClnNode) CreateBolt11Invoice(options *CreateInvoiceOptions) *CreateInvo
 	label, err := GenerateRandomString()
 	CheckError(n.harness.T, err)
 
-	exposePrivateChannels := []string{}
-	if options.IncludeHopHints {
-		exposePrivateChannels = append(exposePrivateChannels, "true")
-	}
 	req := &rpc.InvoiceRequest{
 		Label: label,
 		AmountMsat: &rpc.AmountOrAny{
@@ -524,7 +520,6 @@ func (n *ClnNode) CreateBolt11Invoice(options *CreateInvoiceOptions) *CreateInvo
 				},
 			},
 		},
-		Exposeprivatechannels: exposePrivateChannels,
 	}
 
 	if options.Description != nil {

diff --git a/itest/lntest/lightning_node.go b/itest/lntest/lightning_node.go
@@ -46,11 +46,10 @@ type OpenChannelOptions struct {
 }
 
 type CreateInvoiceOptions struct {
-	AmountMsat      uint64
-	Description     *string
-	Preimage        *[]byte
-	Cltv            *uint32
-	IncludeHopHints bool
+	AmountMsat  uint64
+	Description *string
+	Preimage    *[]byte
+	Cltv        *uint32
 }
 
 type CreateInvoiceResult struct {

diff --git a/itest/lntest/lnd_node.go b/itest/lntest/lnd_node.go
@@ -524,7 +524,7 @@ func (n *LndNode) WaitForChannelReady(channel *ChannelInfo) ShortChannelID {
 func (n *LndNode) CreateBolt11Invoice(options *CreateInvoiceOptions) *CreateInvoiceResult {
 	req := &lnrpc.Invoice{
 		ValueMsat: int64(options.AmountMsat),
-		Private:   options.IncludeHopHints,
+		Private:   true,
 	}
 
 	if options.Description != nil {

diff --git a/itest/notification_test.go b/itest/notification_test.go
@@ -144,8 +144,7 @@ func testOfflineNotificationRegularForward(p *testParams) {
 	log.Printf("Adding bob's invoice")
 	amountMsat := uint64(2100000)
 	bobInvoice := p.BreezClient().Node().CreateBolt11Invoice(&lntest.CreateInvoiceOptions{
-		AmountMsat:      amountMsat,
-		IncludeHopHints: true,
+		AmountMsat: amountMsat,
 	})
 	log.Printf(bobInvoice.Bolt11)
 
@@ -234,8 +233,7 @@ func testOfflineNotificationZeroConfChannel(p *testParams) {
 	amountMsat := uint64(2100000)
 
 	bobInvoice := p.BreezClient().Node().CreateBolt11Invoice(&lntest.CreateInvoiceOptions{
-		AmountMsat:      amountMsat,
-		IncludeHopHints: true,
+		AmountMsat: amountMsat,
 	})
 
 	invoiceWithHint := bobInvoice.Bolt11

diff --git a/itest/regular_forward_test.go b/itest/regular_forward_test.go
@@ -40,8 +40,7 @@ func testRegularForward(p *testParams) {
 	log.Printf("Adding bob's invoice")
 	amountMsat := uint64(2100000)
 	bobInvoice := p.BreezClient().Node().CreateBolt11Invoice(&lntest.CreateInvoiceOptions{
-		AmountMsat:      amountMsat,
-		IncludeHopHints: true,
+		AmountMsat: amountMsat,
 	})
 	log.Printf(bobInvoice.Bolt11)