Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support oauth2 compatible auth responses (uses access_token field, not token) #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support oauth2 compatible auth responses (uses access_token field, not token) #174

wants to merge 1 commit into from

Commits on Sep 9, 2020

  1. Support oauth2 compatible auth resp's (uses 'access_token') 

    Adds support for more container registries, eg: Azure.

According to the docker specs:

    For compatibility with OAuth 2.0, we will also accept token under the name
    access_token. At least one of these fields must be specified, but both may
    also appear (for compatibility with older clients). When both are specified,
    they should be equivalent; if they differ the client's choice is undefined.

Serde doesn't support deriving a Deserialize instance with required fields that
may appear under multiple names, so rather than manually implement the trait
here we use an intermediate struct with a TryFrom implementation.
    @edwardgeorge
    edwardgeorge committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    3afb34e View commit details
    Browse the repository at this point in the history