Add support for OCI Image Index #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a similar fix for pulling OCI Images from registry-1.docker.io.... it involves |
|
@PratikMahajan , I see you have been merging old PRs. May I put this one on your radar? |
PratikMahajan
approved these changes
Feb 6, 2024
chantra
added a commit
to chantra/camallo-dkregistry-rs
that referenced
this pull request
Feb 10, 2024
OCI Image Index (https://github.com/opencontainers/image-spec/blob/v1.0.1/image-index.md) is similar to vnd.docker.distribution.manifest.list.v2 This revives camallo#244 originally created by @luizribeiro A testing client could pull koenkk/zigbee2mqtt:latest with this change. Fixes camallo#243
|
Thank you for reviving this @chantra, I appreciate it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest, I don’t know enough about how Docker image manifests work, but from looking at the documentation it seems like OCI Image Index follows exactly the same format as Manifest Lists. So this makes us use that format for whenever we encounter the OCI Image Index MIME type.
This fixes #243 for me.