Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reload loop on dev mode and support Nuxt 3.11.2 without --no-fork option #80

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rvalledorjr
Copy link

@rvalledorjr rvalledorjr commented May 17, 2024

Fixes #74 and support Nuxt 3.11.2 without --no-fork option

Notes

  • From my testing what caused the strange loop on dev mode was this line nuxt.options.app.baseURL = './' // '/' in adaptElectronConfig function. Removing it fixes the loop issue without affecting the electron prod build.
  • Had to put up a 5-second delay on _listen inline function to prevent the intermittent 404 or 500 error on dev mode.
    • The delay seems to be "hackish" and better solution is welcome.
    • With or without this delay, even if the 404/500 error occurs on the initial page load, it will clear up after doing another page reload.

@shinGangan
Copy link

Hey @rvalledorjr , thank you for your PR support.

I was having trouble with this issue so I'm grateful. 🙏
Are there any additional steps to be taken for this PR? Or has it been completed as is?

@rvalledorjr
Copy link
Author

Hi @shinGangan

Are there any additional steps to be taken for this PR?

None so far. It's complete as far as the strange loop issue is concerned. In a nutshell, the PR basically just apply this manual workaround #74 (comment)

@shinGangan
Copy link

Hi @rvalledorjr , thank you for your comment and response 🙏

I look forward to this PR being merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange loop
2 participants