Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 페이지네이션 기능 구현한다 #33

Merged
merged 2 commits into from
Aug 16, 2023
Merged

feat: 페이지네이션 기능 구현한다 #33

merged 2 commits into from
Aug 16, 2023

Conversation

feb-dain
Copy link
Contributor

@feb-dain feb-dain commented Aug 15, 2023

📄 Summary

페이지네이션 버튼 클릭시 해당 페이지 번호와 함께 충전소 정보 요청 보내는 기능 구현

  • prefetchQuery: 미리 다음 페이지를 불러와 딜레이가 없도록 함
  • keepPreviousData: 요청한 데이터가 올 때까지 이전 데이터를 보여주도록 함
  • refetchOnWindowFocus: 윈도우가 재포커싱될 때마다 refetch 하는 것 방지

🕰️ Actual Time of Completion

3시간

🙋🏻 More

close #30

- prefetchQuery: 미리 다음 페이지를 불러와 딜레이가 없도록 함
- keepPreviousData: 요청한 데이터가 올 때까지 이전 데이터를 보여주도록
  함
- refetchOnWindowFocus: 윈도우가 재포커싱될 때마다 refetch 하는 것 방지

[#30]
@feb-dain feb-dain added the feat 기능 추가 label Aug 15, 2023
@feb-dain feb-dain self-assigned this Aug 15, 2023
@feb-dain feb-dain temporarily deployed to github-pages August 15, 2023 18:58 — with GitHub Actions Inactive
Copy link
Contributor

@drunkenhw drunkenhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안주무시나요
pr에 간단한 설명이 있어서 감사합니다
수고하셨습니다

Comment on lines +41 to +44
const handleChangePage = (_: ChangeEvent<unknown>, page: number) => {
setCurrentPage(page);
currentPageStore.setState(currentPage);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두 군데 다 저장하는 이유가 뭐에요?

Copy link
Contributor Author

@feb-dain feb-dain Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗.. 하나 삭제했습니다!

@feb-dain feb-dain merged commit 339bffb into develop Aug 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

페이지네이션 기능 구현한다
2 participants