-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0116? | Universal JSON Encoding for Domain Types #766
CIP-0116? | Universal JSON Encoding for Domain Types #766
Conversation
…rammatic processing
- New types: TransactionWitnessSet, MIR, BootstrapWitness, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A really great proposal 💪
See, my mainly housekeeping comments.
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Awesome |
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
"format": "hex", | ||
"pattern": "^[0-9a-f]{64}$", | ||
"maxLength": 64, | ||
"minLength": 64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we specify minLength for transaction hashes but not other things, such as keyHashes or addresses?
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
CIP-116 | Add feedback from query layer standardisation workshop #2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is is now a mature proposal, with lots of community technical review.
The author is now working on the Implementation Plan.
Great work 💪
Pre-meeting approval, ready for CIP editors meeting # 88.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise I am more than satisfied by the rounds of review & response: marked Last Check
to keep attention on it until merging when fully ready (re: Implementation Plan).
This is a CIP corresponding to CPS-11.
It includes a json-schema file specifying JSON layout for Babbage-era Cardano domain types.
The markdown file contains motivation for encoding choices and proposed conventions for building schemas for future eras.
(Rendered version)