Fix Should rules ignoring classes with empty findings

src/Rule/Assertion/Relation/RelationAssertion.php

@@ -4,6 +4,8 @@
 
 use PHPat\Configuration;
 use PHPat\Rule\Assertion\Assertion;
+use PHPat\Rule\Assertion\Relation\ShouldExtend\ShouldExtend;
+use PHPat\Rule\Assertion\Relation\ShouldImplement\ShouldImplement;
 use PHPat\Selector\Classname;
 use PHPat\Selector\SelectorInterface;
 use PHPat\ShouldNotHappenException;
@@ -95,6 +97,11 @@ protected function ruleApplies(Scope $scope, array $nodes): bool
             return false;
         }
 
+        // Can not skip if the rule is a ShouldExtend or ShouldImplement rule
+        if (is_a($this, ShouldExtend::class) || is_a($this, ShouldImplement::class)) {
+            return true;
+        }
+
         if (empty($nodes)) {
             return false;
         }

tests/unit/rules/ShouldExtend/SimpleParentClassTest.php

@@ -0,0 +1,49 @@
+<?php declare(strict_types=1);
+
+namespace Tests\PHPat\unit\rules\ShouldExtend;
+
+use PHPat\Configuration;
+use PHPat\Rule\Assertion\Relation\ShouldExtend\ParentClassRule;
+use PHPat\Rule\Assertion\Relation\ShouldExtend\ShouldExtend;
+use PHPat\Selector\Classname;
+use PHPat\Statement\Builder\StatementBuilderFactory;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPStan\Type\FileTypeMapper;
+use Tests\PHPat\fixtures\Simple\SimpleAbstractClass;
+use Tests\PHPat\fixtures\Simple\SimpleClass;
+use Tests\PHPat\unit\FakeTestParser;
+
+/**
+ * @extends RuleTestCase<ParentClassRule>
+ * @internal
+ * @coversNothing
+ */
+class SimpleParentClassTest extends RuleTestCase
+{
+    public const RULE_NAME = 'test_SimpleClassShouldExtendSimpleAbstractClass';
+
+    public function testRule(): void
+    {
+        $this->analyse(['tests/fixtures/Simple/SimpleClass.php'], [
+            [sprintf('%s should extend %s', SimpleClass::class, SimpleAbstractClass::class), 5],
+        ]);
+    }
+
+    protected function getRule(): Rule
+    {
+        $testParser = FakeTestParser::create(
+            self::RULE_NAME,
+            ShouldExtend::class,
+            [new Classname(SimpleClass::class, false)],
+            [new Classname(SimpleAbstractClass::class, false)]
+        );
+
+        return new ParentClassRule(
+            new StatementBuilderFactory($testParser),
+            new Configuration(false, true, false),
+            $this->createReflectionProvider(),
+            self::getContainer()->getByType(FileTypeMapper::class)
+        );
+    }
+}

tests/unit/rules/ShouldImplement/SimpleImplementedInterfacesTest.php

@@ -0,0 +1,49 @@
+<?php declare(strict_types=1);
+
+namespace Tests\PHPat\unit\rules\ShouldImplement;
+
+use PHPat\Configuration;
+use PHPat\Rule\Assertion\Relation\ShouldImplement\ImplementedInterfacesRule;
+use PHPat\Rule\Assertion\Relation\ShouldImplement\ShouldImplement;
+use PHPat\Selector\Classname;
+use PHPat\Statement\Builder\StatementBuilderFactory;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPStan\Type\FileTypeMapper;
+use Tests\PHPat\fixtures\Simple\SimpleClass;
+use Tests\PHPat\fixtures\Simple\SimpleInterface;
+use Tests\PHPat\unit\FakeTestParser;
+
+/**
+ * @extends RuleTestCase<ImplementedInterfacesRule>
+ * @internal
+ * @coversNothing
+ */
+class SimpleImplementedInterfacesTest extends RuleTestCase
+{
+    public const RULE_NAME = 'test_SimpleClassShouldImplementSimpleInterface';
+
+    public function testRule(): void
+    {
+        $this->analyse(['tests/fixtures/Simple/SimpleClass.php'], [
+            [sprintf('%s should implement %s', SimpleClass::class, SimpleInterface::class), 5],
+        ]);
+    }
+
+    protected function getRule(): Rule
+    {
+        $testParser = FakeTestParser::create(
+            self::RULE_NAME,
+            ShouldImplement::class,
+            [new Classname(SimpleClass::class, false)],
+            [new Classname(SimpleInterface::class, false)]
+        );
+
+        return new ImplementedInterfacesRule(
+            new StatementBuilderFactory($testParser),
+            new Configuration(false, true, false),
+            $this->createReflectionProvider(),
+            self::getContainer()->getByType(FileTypeMapper::class)
+        );
+    }
+}