Merge pull request #83 from cisco-open/fix/redundant-warning/SDK-589

fix(console-exporter): rm redundant warning for debug exporter

cisco_telescope/options.py

@@ -39,7 +39,10 @@ def __init__(
         if self.exporter_type not in project_consts.ALLOWED_EXPORTER_TYPES:
             raise ValueError("Unsupported exported type")
 
-        if not self.collector_endpoint:
+        if (
+            self.exporter_type is not project_consts.CONSOLE_EXPORTER_TYPE
+            and not self.collector_endpoint
+        ):
             logging.warning(
                 "Warning: Custom exporter is set without collector endpoint"
             )

tests/test_options.py

@@ -14,7 +14,6 @@
 limitations under the License.
 """
 import os
-from distutils.util import strtobool
 import unittest
 from unittest import mock
 
@@ -118,6 +117,18 @@ def test_missing_collector_url_warning(self):
                 "Warning: Custom exporter is set without collector endpoint",
             )
 
+    def test_rm_collector_url_warning_on_console_exporter(self):
+        with self.assertLogs() as captured:
+            captured.records.append(
+                "dummy record to ensure no real record was generated"
+            )
+            _ = options.ExporterOptions(exporter_type=consts.CONSOLE_EXPORTER_TYPE)
+            self.assertEqual(len(captured.records), 1)
+            self.assertEqual(
+                captured.records[0],
+                "dummy record to ensure no real record was generated",
+            )
+
     @mock.patch.dict(
         os.environ,
         {