Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to express 5 #4664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade to express 5 #4664

wants to merge 2 commits into from

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Nov 15, 2024

Changes proposed in this pull request:

  • Upgrade to express 5
  • Switches the local port for UAA to 9001

security considerations

Upgrading express should provide security upgrades by avoiding relying on outdated dependencies

@drewbo
Copy link
Contributor Author

drewbo commented Nov 15, 2024

I used the checklist in #4611 (generated from the migration guide) to ensure we hit all the necessary items. A summary of the changes:

  • Updated optional path parameter syntax
  • Updated wildcard path syntax (requires naming)
  • Removed extended: false from urlencoded since it's now the default

The new promise rejections should only be helpful, we might have a few unnecessary try/catch blocks out there but I didn't want to investigate each use.

@drewbo drewbo requested a review from a team November 15, 2024 18:14
@cloud-gov-pages-operations
Copy link
Contributor

🤖 This is an automated code coverage report

Total coverage (lines): 5.48%
Coverage diff: 0% 📈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewbo @cloud-gov-pages-operations