Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore data migration #17

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Chore data migration #17

merged 2 commits into from
Oct 29, 2024

Conversation

jamesthebrooks
Copy link
Contributor

Changes proposed in this pull request:

  • Migrated data from jekyll site to here




- label: cloud.gov knowledge base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this cloud.gov knowledge base config. It is a relic of the Decap CMS that is no longer used in the cloud.gov site.

@@ -1,11 +1,26 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious -- do we gain anything by having assetPaths checked in? in another project, we're looking at adding it to the gitignore because its so noisy in diffs. If you agree, could you delete it and add it to the ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also been curious about this... Let me get it ignored after the others have been merged. I'll make a note. Do we even need _site at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Slack discussion, removing "_site" from tracking and adding an issue here for the Pages template: cloud-gov/pages-uswds-11ty#78

@@ -4,16 +4,53 @@
# This is simple, hopefully provides you with a good enough example to make changes as needed
- name: GSA
url: https://gsa.gov
description: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec dapibus interdum pellentesque. Integer eu vehicula elit. Sed cursus magna in dui suscipit rhoncus.
description: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec dapibus interdum pellentesque. Integer eu vehicula elit. Sed cursus magna in dui suscipit rhoncus.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these descriptions for? do you know? I'm wondering if this is only used in decap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might even be example data? I honestly don't know and will defer to @apburnes and you.

@sknep sknep self-requested a review October 29, 2024 15:18
sknep
sknep previously approved these changes Oct 29, 2024
Copy link

@sknep sknep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you address the comments, go ahead and merge :)

@jamesthebrooks jamesthebrooks merged commit 54f1515 into main Oct 29, 2024
3 checks passed
@jamesthebrooks jamesthebrooks deleted the chore-data-migration branch November 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants