-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding content for home page, pricing, get started, contact us #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these documents linked to from these files? why are they included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These weren't in the assets folder to begin with in cg so they didn't make it in. I just updated the code base to move everything inside /resources to /assets/documents. I updated paths where I saw the files referenced and created redirects for anyone who might be trying to link to them directly. Likely some of these files can be permanently deleted as well, but this was not addressed in the PDFs pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK lets either drop all of them from this PR or go through them and pick which are actually needed. I don't want to bring over more files we don't need. Can you tell if these are directly linked to in the markdown content you're pulling over?
is this ready for review? |
Yes, good to look at now. I think the main thing worth noting after a couple updates is the new resource files added in from the resources folder. I've moved from to assets/documents/* and added redirects. Some files are not referenced anywhere, but I'll leave it to your judgement whether we delete them entirely and redirect to another page or something else. |
_assets/documents/casestudy-fec.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect to https://cloud.gov/docs/customer-stories/fec/
content/redirects/casestudy-fec.html
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/casestudy-fec.pdf/index.html | |||
redirect: /assets/documents/casestudy-fec.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of redirecting to a PDF, redirect to this URL:
redirect: /assets/documents/casestudy-fec.pdf | |
redirect: /docs/customer-stories/fec/ |
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/cloud-gov-customers.pdf/index.html | |||
redirect: /assets/documents/cloud-gov-customers.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect: /assets/documents/cloud-gov-customers.pdf | |
redirect: /docs/customer-stories/epa-airnow-gov/ |
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/cloudgov-overview-2018.pdf/index.html | |||
redirect: /assets/documents/cloudgov-overview-2018.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect: /assets/documents/cloudgov-overview-2018.pdf | |
redirect: /docs/overview/cloudgov-benefits/ |
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/Contingency-plan-exercise-template.docx/index.html | |||
redirect: /assets/documents/Contingency-plan-exercise-template.docx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect: /assets/documents/Contingency-plan-exercise-template.docx | |
redirect: /docs/ops/moved/ |
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/Contingency-plan-exercise-template.pdf/index.html | |||
redirect: /assets/documents/Contingency-plan-exercise-template.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect: /assets/documents/Contingency-plan-exercise-template.pdf | |
redirect: /docs/ops/moved/ |
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/cloud.gov-CIS-Worksheet.xlsx/index.html | |||
redirect: /assets/documents/cloud.gov-CIS-Worksheet.xlsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect: /assets/documents/cloud.gov-CIS-Worksheet.xlsx | |
redirect: /docs/ops/moved/ |
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/cloudgov_cost_estimator.xlsx/index.html | |||
redirect: /assets/documents/cloudgov_cost_estimator.xlsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect: /assets/documents/cloudgov_cost_estimator.xlsx | |
redirect: /pricing |
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /resources/cloudgov_cost_estimator.ods/index.html | |||
redirect: /assets/documents/cloudgov_cost_estimator.ods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect: /assets/documents/cloudgov_cost_estimator.ods | |
redirect: /pricing |
<a href="https://docs.google.com/forms/d/1vcsvQ64qt5mYNyVajcwtYDRMqEOyPzsXZBGM5c4_BD8/edit">The public DevOps channel on TTS's Slack (sign up at using this form).</a>TTS Slack | ||
</li> | ||
<li> | ||
<a href="https://www.cloudfoundry.org/community/">Cloud Foundry communities (Slack, newsletters, mail lists)</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this open in a new window in the built version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
81944b4
to
539b276
Compare
adding content for home page, pricing, get started, contact us