Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on invalid config #19

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Fail on invalid config #19

wants to merge 17 commits into from

Conversation

Benbentwo
Copy link
Member

what

  • remove || statement

why

  • Causes this action to succeed when in fact it has failed

goruha
goruha previously approved these changes Dec 21, 2023
View reviewed changes
milldr
milldr requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@milldr milldr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this action needs to return {} if the setting does not exist

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

@Benbentwo can you resolve the merge conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@goruha goruha goruha left review comments

Assignees
No one assigned
Labels
stale This PR has gone stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Benbentwo @hans-d @goruha @milldr