Changes root volume default-type to gp3 #72
Conversation
Add root block volume type
…locking multi-region deploy
…-iam Prevents module from blocking on 2nd+ region by including AWS region_name in IAM role names
iam.tf
Outdated
| @@ -6,7 +6,7 @@ resource "aws_iam_instance_profile" "default" { | |||
|
|
|||
| resource "aws_iam_role" "default" { | |||
| count = (module.this.enabled && local.instance_profile_count == 0) ? 0 : 1 | |||
| name = module.this.id | |||
| name = "${module.this.id}-${data.aws_region}" | |||
There was a problem hiding this comment.
I don't believe we'd accept this change as 1) I don't believe this would be a valid reference (i.e. it would fail) and 2) the develop can add the region (or region identifier) to their name via the context variables that make up module.this.id.
Can you please remove this and the rename from default => current before we potentially move this PR forward?
There was a problem hiding this comment.
Didn't mean for this to be included. This PR was based on our master & not the volume-type specific branch.
I've based a PR on that branch & "started over" here: #77
| variable "root_block_device_volume_type" { | ||
| type = string | ||
| default = "gp3" | ||
| description = "The volume type." |
There was a problem hiding this comment.
Can you please list the valid values here? Or if this module requires 0.13+ then please include a validation block to ensure the user is only passing in accepted values.
There was a problem hiding this comment.
Yes, done in PR #77.
Closing this PR because it included incomplete edits from a different feature.
…-iam Fix data reference to aws_region.name
This is a minor change that could offer a very small cost-savings for bastion hosts. We would like to see it reflected upstream if possible.
If the change to a
gp3default is concerning due to a large volume of TF updates, could the support for specifyingvolume_typestill be added so we can manually specifygp3?what
gp2to the newergp3typegp2orstandardmagnetic volumes to be specifiedwhy
gp3type now being set as default is both less expensive per-GB and more-performant for small volumesgp2is neededgp2orstandardvolume-types if requiredreferences