-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the logic of the complex balance #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihoroleksiienko
changed the title
Ref after token transfer
Move after token transfer hooks
Jul 8, 2024
ihoroleksiienko
requested review from
igorsenych-cw and
EvgeniiZaitsevCW
as code owners
July 8, 2024 13:17
ihoroleksiienko
changed the title
Move after token transfer hooks
Improve the logic of the complex balance
Jul 9, 2024
EvgeniiZaitsevCW
previously approved these changes
Jul 9, 2024
igorsenych-cw
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
X
account has 100 tokens in total.A
.B
.transferFrozen()
function can transfer all 10 frozen tokens fromX
toB
. Previously it did not work. ThetransferFrozen()
function could only transfer tokens fromX
to the purposed accountA
._afterTokenTransfer()
function of specific base contracts to the same-name internal function of theCWToken
base contract. It allows to concentrate the check logic of the complex balance in a single place instead of spreading it among multiple functions.transferFrozen()
function when other limitations exist.Test coverage
New functionality was fully covered with tests.