Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional logs for rollout controller #302

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

pasha-codefresh
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

github-actions bot commented Feb 6, 2024

Go Published Test Results

2 066 tests   2 066 ✅  2m 48s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 855b76e.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9c756f9) 81.68% compared to head (855b76e) 81.71%.
Report is 4 commits behind head on release-1.6.

Files Patch % Lines
rollout/controller.go 50.00% 6 Missing ⚠️
rollout/replicaset.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6     #302      +/-   ##
===============================================
+ Coverage        81.68%   81.71%   +0.03%     
===============================================
  Files              134      134              
  Lines            20496    20544      +48     
===============================================
+ Hits             16742    16788      +46     
- Misses            2886     2887       +1     
- Partials           868      869       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 6, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 23m 49s ⏱️
103 tests  92 ✅  6 💤 5 ❌
420 runs  388 ✅ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit 855b76e.

@pasha-codefresh pasha-codefresh merged commit 0e79d27 into release-1.6 Feb 6, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants