Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Request: remove PoR, add merkle root #590

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

markspanbroek
Copy link
Member

@markspanbroek markspanbroek commented Oct 19, 2023

Update Storage Requests that go on chain to accomodate new proving scheme:

  • Remove PoR parameters
  • Remove total number of chunks
  • Add merkle root of the dataset

Depends on change in smart contracts: codex-storage/codex-contracts-eth#72
Requires #566 to be merged first.

Closes #579

@dryajov
Copy link
Contributor

dryajov commented Oct 20, 2023

related to #593

Base automatically changed from blockexchange-uses-merkle-tree to master November 14, 2023 12:02
@markspanbroek markspanbroek marked this pull request as ready for review November 22, 2023 13:58
Copy link
Member

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markspanbroek markspanbroek enabled auto-merge (squash) November 27, 2023 11:36
@markspanbroek markspanbroek merged commit b62ccf5 into master Nov 27, 2023
8 checks passed
@markspanbroek markspanbroek deleted the update-request-parameters branch November 27, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Request for new proving scheme - contract to store Merkle Root + Manifest CID
3 participants