feat(slot-reservations): support enforcement of slot reservations before filling slot #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
approved these changes
Oct 3, 2024
emizzle
force-pushed
the
feat/slot-reservations/4-add-slotreservationfull-event
branch
from
9fb5326
to
d6d2e72
Compare
Base automatically changed from
feat/slot-reservations/4-add-slotreservationfull-event
to
master
October 5, 2024 02:47
|
@benbierens with this change in, a |
emizzle
force-pushed
the
feat/slot-reservations/6-enforce-slot-reservations
branch
from
dd5a31c
to
7fb8e77
Compare
veaceslavdoina
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #933.
This is being implemented as part of a longer list of tasks for slot reservations to prevent PRs from being too large.
The contracts changes included in this PR enforce that a slot is reserved before it is filled.
This PR adds support for these updates by updating the tests to reserve slots before filling them.