Distributor accept multiple HA Tracker pairs in the same request (find first) #6279
+413
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardscaueru
force-pushed
the
ha_tracker_mixed_replicas_find_first
branch
6 times, most recently
from
db369f5
to
80c8826
Compare
eduardscaueru
force-pushed
the
ha_tracker_mixed_replicas_find_first
branch
from
80c8826
to
6145139
Compare
3 tasks
eduardscaueru
force-pushed
the
ha_tracker_mixed_replicas_find_first
branch
4 times, most recently
from
54cb814
to
47595b0
Compare
…A pairs (cluster, replica) in the same requets/batch. This can be enabled with a new flag, accept_mixed_ha_samples, an will take effect only if accept_ha_samples is set to true. Fixed test by reducing the number of ingesters to 2 and replication factor to 2. Added config reference. Do not remove replica label if cluster label is not present. Added more HA mixed replicas tests with no cluster and replica labels and with cluster label only. Added e2e test for mixed HA samples in the same request. Refactored distributor mixed HA samples logic. Added experimental flag for accept_mixed_ha_samples. Added error for non valid HA samples. Refactored method to compute HA pairs based on the KV store. Removed ha pairs map from function params. Signed-off-by: eduardscaueru <edi_scaueru@yahoo.com>
eduardscaueru
force-pushed
the
ha_tracker_mixed_replicas_find_first
branch
from
47595b0
to
19a7adc
Compare
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
reviewed
Nov 15, 2024
friedrichg
reviewed
Nov 15, 2024
Signed-off-by: eduardscaueru <edi_scaueru@yahoo.com>
….com/eduardscaueru/cortex into ha_tracker_mixed_replicas_find_first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added new implementation that makes the distributor accept multiple HA pairs (cluster, replica) in the same requets/batch. This can be enabled with a new flag, accept_mixed_ha_samples, an will take effect only if accept_ha_samples is set to true.
This implementation will identify for every unique HA pair of (cluster, replica) which are the elected replicas, before the timeseries from the batch are processed. When they are processed in the prepareSeriesKeys method, for every timeseries it checks if the pair (cluster, replica) has error in the HA pairs map and if yes, it is discarded and moves on with the other timeseries from the batch.
It also ensures that when the cluster label is missing, the replica label is not removed.
Which issue(s) this PR fixes:
Fixes #6256
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]