Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where adding a message stream would return error from API #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kjellknapen
Copy link
Member

According to the api docs the message streams param in de template message needs to be in string format. Otherwise the api will return an error message

Screenshot 2022-05-10 at 13 35 33

Copy link
Member

@remipelhate remipelhate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that does not comply with their SDK though (as reported by PHPStan 👉🏻 https://github.com/craftzing/laravel-postmark-notification-channel/runs/6369415840?check_suite_focus=true).

I presume the SDK handles this internally, in which case it might be better to follow the SDK. Or did you encounter a specific issue with the current implementation?

@kjellknapen
Copy link
Member Author

Hmm, weird! Dan is dat volgens mij ook een fout in SDK 🤔 Want ik had messagestreams gebruikt in Royal Botania en daar kreeg ik een JSON error als ik het als array doorstuurde, maar als het een string was werkte het wel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants