Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: wrong gas price when using basefee of minus one height when trace tx #559

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 11, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (64bd2de) to head (271c678).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 22.22% 5 Missing and 2 partials ⚠️
rpc/backend/tracing.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #559      +/-   ##
===========================================
- Coverage    46.21%   46.20%   -0.02%     
===========================================
  Files          181      181              
  Lines        18132    18146      +14     
===========================================
+ Hits          8380     8384       +4     
- Misses        9036     9043       +7     
- Partials       716      719       +3     
Files with missing lines Coverage Δ
rpc/backend/tracing.go 56.08% <40.00%> (-0.44%) ⬇️
x/evm/keeper/grpc_query.go 77.39% <22.22%> (-0.92%) ⬇️

@mmsqe mmsqe requested a review from yihuang November 11, 2024 02:25
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in slack, the root cause should be that we need to emulate begin blocker logic to recreate correct context for tracing execution, right?

Signed-off-by: mmsqe <tqd0800210105@gmail.com>
@mmsqe
Copy link
Collaborator Author

mmsqe commented Nov 12, 2024

As we discussed in slack, the root cause should be that we need to emulate begin blocker logic to recreate correct context for tracing execution, right?

I don't find good way to fill the empty consensus params, and get basefee is simpler.

@mmsqe mmsqe merged commit 4fb45a3 into crypto-org-chain:develop Nov 12, 2024
37 of 41 checks passed
@yihuang yihuang deleted the fix_trace branch November 12, 2024 13:21
yihuang pushed a commit that referenced this pull request Nov 13, 2024
* Problem: incorrect balance when no tracer in predecessors (#558)

* Problem: incorrect balance when no tracer in predecessors

* lint

* Problem: wrong gas price when using basefee of minus one height when trace tx (#559)

* Problem: wrong gas price when using basefee of minus one height when trace tx

* add basefee req

---------

Signed-off-by: mmsqe <tqd0800210105@gmail.com>

* fix test

---------

Signed-off-by: mmsqe <tqd0800210105@gmail.com>
yihuang pushed a commit that referenced this pull request Nov 14, 2024
…trace tx (#559)

* Problem: wrong gas price when using basefee of minus one height when trace tx

* add basefee req

---------

Signed-off-by: mmsqe <tqd0800210105@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants