-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: wrong gas price when using basefee of minus one height when trace tx #559
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #559 +/- ##
===========================================
- Coverage 46.21% 46.20% -0.02%
===========================================
Files 181 181
Lines 18132 18146 +14
===========================================
+ Hits 8380 8384 +4
- Misses 9036 9043 +7
- Partials 716 719 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed in slack, the root cause should be that we need to emulate begin blocker logic to recreate correct context for tracing execution, right?
Signed-off-by: mmsqe <tqd0800210105@gmail.com>
I don't find good way to fill the empty consensus params, and get basefee is simpler. |
* Problem: incorrect balance when no tracer in predecessors (#558) * Problem: incorrect balance when no tracer in predecessors * lint * Problem: wrong gas price when using basefee of minus one height when trace tx (#559) * Problem: wrong gas price when using basefee of minus one height when trace tx * add basefee req --------- Signed-off-by: mmsqe <tqd0800210105@gmail.com> * fix test --------- Signed-off-by: mmsqe <tqd0800210105@gmail.com>
…trace tx (#559) * Problem: wrong gas price when using basefee of minus one height when trace tx * add basefee req --------- Signed-off-by: mmsqe <tqd0800210105@gmail.com>
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)