Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-std-ify hpke-rs-crypto #50

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Nov 24, 2023

this is a semver breaking change because the "std" Cargo feature is added as an opt-in feature.

this makes the crate itself not depend on libstd but to achieve true no-std support the dependencies need to not pull in libstd and for that #47 and #49 are required

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Cargo.toml has a conflict.
Otherwise this looks good to me.
Also, would you mind adding a CI job for no-std when things are no-std? Doesn't have to be in here yet.

@japaric
Copy link
Contributor Author

japaric commented Nov 27, 2023

fixed the merge conflict. I'll open a separate PR for the CI job

@japaric japaric mentioned this pull request Nov 27, 2023
@franziskuskiefer franziskuskiefer merged commit 9cfc218 into cryspen:main Nov 27, 2023
13 of 14 checks passed
@japaric japaric deleted the crypto-no-std branch November 27, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants