Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ep/h2c #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ep/h2c #17

wants to merge 4 commits into from

Commits on Mar 28, 2022

  1. h2c: fix perlcritic "Variable declared in conditional statement" 

    perlcritic --verbose 6 h2c gives the following result:

Variable declared in conditional statement at line 400, near 'my $lib="--libcurl - -x localhost:0 " if($uselibcurl);'.  (Severity: 5)

Fix it.
    @devzero2000
    devzero2000 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    e34e35e View commit details
    Browse the repository at this point in the history

  2. h2c: fix perlcritic "Bareword file handle" 

     perlcritic --verbose 6 h2c gives the following result:

Bareword file handle opened at line 406, near 'open(C, "$curlcmd 2>/dev/null|");'.  (Severity: 5)

Fix it.
    @devzero2000
    devzero2000 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    57bf937 View commit details
    Browse the repository at this point in the history

  3. h2c: fix perlcritic 'Two-argument "open" used at' 

    perlcritic --verbose 6 h2c gives the following result:

Two-argument "open" used at line 405, near 'open(C, "$curlcmd 2>/dev/null|");'.  (Severity: 5)

Fix it.
    @devzero2000
    devzero2000 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    bfac617 View commit details
    Browse the repository at this point in the history

  4. h2c: fix perlcritic "Code before strictures are enabled" 

     perlcritic --verbose 6 h2c gives the following result:

Code before strictures are enabled at line 5, near 'sub usage {'.  (Severity: 5)

For fix it:

	- Add "use strict; use warnings"

	- Add where necessary the "my" keyword to the lexically scoped variables.

	- Fix also some uninitialized variables.
    @devzero2000
    devzero2000 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    544ca88 View commit details
    Browse the repository at this point in the history