-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps: add MapKeys, MapValues, and related helpers #86
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo, otherwise looks good!
Co-authored-by: Mikaël Mayer <MikaelMayer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, made some non-blocking suggestions (because we have the opportunity to improve naming before this code is more locked down)
See also: #119. I don't want to block on adding this under |
I'll take care of syncing to |
This PR addresses a common use case where one wants to map an injective function over the keys of the map, retaining the values.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.