add handle_ping/1 pool callback #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Nov 1, 2024
| max_idle_pings: max_idle_pings | ||
| max_idle_pings: max_idle_pings, | ||
| pool_idle_timeout: pool_idle_timeout, | ||
| last_activity_ts: System.monotonic_time(:millisecond) |
There was a problem hiding this comment.
Yes, this is exactly my concern. If we have to track this, this is now state necessary on every single nimble pool... but not all of them may need it. It is better if you track this on Finch side.
There was a problem hiding this comment.
Although I think the implementation overhead is very low, I agree that not all clients may need it.
So it’s all good with me. Feel free to close this PR and the issue, and I’ll move forward with the implementation on the Finch side. Thanks for the feedback!
There was a problem hiding this comment.
Thank you for trying it out! And, if the Finch side for some reason is not enough, we already have what is necessary to implement it here. :)
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46
Let me know what you think about this approach @josevalim!