dcrjson: Add pay to contract hash support. #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
changed the title
davecgh
requested changes
Jun 4, 2018
davecgh
requested changes
Jun 6, 2018
dcrjson/walletsvrcmds.go
Outdated
| @@ -318,6 +318,14 @@ func NewGetBalanceCmd(account *string, minConf *int) *GetBalanceCmd { | |||
| } | |||
| } | |||
|
|
|||
| type GetContractHashCmd struct { | |||
There was a problem hiding this comment.
Missing comment for auto doc generation.
dcrjson/walletsvrcmds.go
Outdated
| FilePath []string | ||
| } | ||
|
|
||
| func NewGetContractHashCmd(filepaths []string) *GetContractHashCmd { |
There was a problem hiding this comment.
Missing comment for auto doc generation.
davecgh
requested changes
Jun 7, 2018
| FilePath []string | ||
| } | ||
|
|
||
| // NewGetBalanceCmd returns a new instance which can be used to issue a |
dcrjson/walletsvrresults.go
Outdated
| @@ -41,6 +41,11 @@ type GetBestBlockResult struct { | |||
| Height int64 `json:"height"` | |||
| } | |||
|
|
|||
| // GetContractHash models the data from the getcontracthash command. | |||
There was a problem hiding this comment.
Sorry about that Dave.
davecgh
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required changes to implement BIP175 decred/dcrwallet#1132 into Decred. Allows two new RPC methods (1) getcontracthashes and (2) getpaytocontractaddress. This loose coupling allows users to grab just the contract(s) hash if needed and a contract P2PKH.