Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BIP-0021 support #2418

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Add BIP-0021 support #2418

merged 1 commit into from
Feb 25, 2020

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Feb 11, 2020

closes #2365

vctt94
vctt94 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested for same address and different values, then changed address and it also worked.

WhatsApp Image 2020-02-18 at 10 30 24

WhatsApp Image 2020-02-18 at 10 31 09

WhatsApp Image 2020-02-18 at 10 31 48
WhatsApp Image 2020-02-18 at 10 32 33

matheusd
matheusd reviewed Feb 20, 2020
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as intended and the code is good for it, so in that regards it's approved by me.

But it's kinda useless to have this without any other wallets (specially mobile) also supporting sending by a BIP0021 compatible. Do the current mobile wallets do that?

If we're going the BIP0021 route, then at some point we'll also want to support sending to these kinds of addresses from Decrediton.

@bgptr
Copy link
Collaborator Author

bgptr commented Feb 22, 2020

@matheusd: thank you for your review, I agree with you. In regards to the mobile wallets, I suppose the upcoming builds will support it. The related PR is merged in dcrandroid and there is a related open PR in dcrios.

@matheusd
Copy link
Member

Can you link to the relevant PRs here?

@bgptr
Copy link
Collaborator Author

bgptr commented Feb 25, 2020

@matheusd sure. planetdecred/dcrandroid#411 and planetdecred/dcrios#581

@matheusd
Copy link
Member

Thanks! Makes sense to have this in decrediton then.

@alexlyp alexlyp merged commit 62b7103 into decred:master Feb 25, 2020
@bgptr bgptr deleted the BIP-0021-support branch February 9, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vctt94 vctt94 vctt94 approved these changes

@matheusd matheusd matheusd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BIP-0021 support
4 participants
@bgptr @matheusd @vctt94 @alexlyp