Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🔖 making better #92

Merged
merged 8 commits into from
Oct 16, 2023
Merged

feat: 🔖 making better #92

merged 8 commits into from
Oct 16, 2023

Conversation

equiman
Copy link
Member

@equiman equiman commented Oct 16, 2023

Added

  • prompt to continue excluding incompatible flags
  • e2e testing for install and add commands

Fixed

  • global flag position on yarn and yarn@berry
  • package parameter on add command

@equiman
feat: ✨ not compatible flag
b8258aa 
add prompts when flag is not compatible
@equiman
Merge pull request #88 from deinsoftware/refactor/move-to-monorepo
07a690f 
feat: ✨ not compatible flag
@equiman
fix: 🐛 global position
9b44a52 
fix correct global flag position on yarn and yarn@berry
@equiman
Merge pull request #89 from deinsoftware/refactor/move-to-monorepo
181221d 
fix: 🐛 global position
@equiman
chore: 📌 bump versions
67cd5e4 
bump package versions
@equiman
Merge pull request #90 from deinsoftware/refactor/move-to-monorepo
372aa34 
chore: 📌 bump versions
@equiman
test: ✅ add and install commands
208bd20 
create e2e test for add and install command
@equiman
Merge pull request #91 from deinsoftware/refactor/move-to-monorepo
1a842b2 
test: ✅ add and install commands
@equiman equiman self-assigned this Oct 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

36.0% 36.0% Coverage
30.2% 30.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@equiman equiman merged commit 0c5950a into main Oct 16, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@equiman equiman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@equiman