feat: dont underscore numbers when formatting module names #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not sure the regex would want to handle something as complex as "allow a-Za-z0-9 but if the string starts with 0-9 then prepend |
c43721
force-pushed
the
dev/c43721/803-numbers-in-modules
branch
from
2a66a96
to
76fd786
Compare
|
@c43721 yes it should handle the case of a starting number |
c43721
force-pushed
the
dev/c43721/803-numbers-in-modules
branch
from
523e7ea
to
ada08ad
Compare
|
@c43721 for test, you can update the module doc name in tests/testdata/multiple/b.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jsr-io/jsr#803 but I'd like to know how or if I could better test this.
I eventually got here by looking at how the identifier for the file was created:
The identifier replacing all non-characters with underscores seems to be the source so adjusting the regex to allow numbers.
Though this regex might need to account for a leading number and replace that since you can't have a module identifier prefixed by a number (must be a character)