-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-19386 Add Checklist template #796
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
commented
Oct 16, 2024
randimays
commented
Oct 16, 2024
randimays
commented
Oct 16, 2024
randimays
commented
Oct 16, 2024
randimays
commented
Oct 16, 2024
randimays
commented
Oct 16, 2024
randimays
commented
Oct 18, 2024
randimays
commented
Oct 18, 2024
randimays
commented
Oct 18, 2024
randimays
force-pushed
the
19386-checklist-template
branch
from
October 18, 2024 18:47
23f816a
to
23d34b1
Compare
randimays
force-pushed
the
19386-checklist-template
branch
from
November 13, 2024 17:37
4c22c0f
to
af3975a
Compare
randimays
commented
Nov 13, 2024
randimays
commented
Nov 13, 2024
randimays
commented
Nov 13, 2024
randimays
commented
Nov 13, 2024
Closing this and creating a new PR to target an integration branch instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Resources & Support Checklist template.
Specifics:
data-next-template
attributes on everything in thetemplates
folder. I saw that this was partly implemented and thought it would be helpful to get it done so we can easily identify components from the browser as we developdata-
attributes that pointed specifically tocontent-build
templates to avoid confusion<Link>
componentyarn build
Design System specifics
Ticket
Developer Task
Tasks
Testing Steps
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
Screenshots
Mobile
Tablet
Desktop
Reviewer
Reviewing a PR
This section lists items that need to be checked or updated when making changes to this repository.
Standard Checks
Tasks
Merging an Approved Layout
When merging a layout, you must ensure that the content type has been turned on for
next-build
inside theCMS
. This CMS flag must be turned on for editors to preview their work using the next build preview server.Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.
The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.
Merging a Non-Approved Layout
Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the
main
branch. It is imperative that we do not push anything live that has not been approved.Ensure that this layout has been added to the templates.md file with the current status of the work.