Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19386 Add Checklist template #796

Closed
wants to merge 51 commits into from
Closed

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Oct 16, 2024

Description

Adds Resources & Support Checklist template.

Specifics:

  • Please review the comments within the diffs; they provide context for some of the changes
  • Consistently applied data-next-template attributes on everything in the templates folder. I saw that this was partly implemented and thought it would be helpful to get it done so we can easily identify components from the browser as we develop
    • This also includes removing the data- attributes that pointed specifically to content-build templates to avoid confusion
  • Removes the unused custom <Link> component
  • Fixes some Typescript errors from the yarn build
  • Adjusts Medallia survey code to match the content-build implementation; we won't be able to test this code until it hits staging (known issue that Medallia doesn't work in lower environments than staging)

Design System specifics

  • Updates the design system library dependencies
  • Updates some components that had already been added to this repo but were out of date (and needed web components)
    • this reduces our ability to have full unit test coverage as you cannot simulate events on web components (this is a known issue in vets-website)
  • DST made adjustments made to the names of breakpoints to reduce reliance on the Formation library. These changes are in content-build and vets-website now but needed to be made in next-build (see VADS vs. USWDS values here)

Ticket

Developer Task

Tasks

Testing Steps

  • Validate that the Events / Events Listing templates are not negatively impacted by the upgrade to the latest component-library version
  • Validated updated generator template for query test files

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Screenshots

Mobile
Screenshot 2024-10-29 at 1 55 01 PM
Screenshot 2024-10-29 at 1 55 11 PM
Screenshot 2024-10-29 at 1 55 20 PM
Screenshot 2024-10-29 at 1 55 29 PM
Screenshot 2024-10-29 at 1 55 38 PM
Tablet
Screenshot 2024-10-29 at 1 57 15 PM
Screenshot 2024-10-29 at 1 57 26 PM
Screenshot 2024-10-29 at 1 57 35 PM
Screenshot 2024-10-29 at 1 57 52 PM
Screenshot 2024-10-29 at 1 57 59 PM
Desktop
Screenshot 2024-10-29 at 2 01 19 PM
Screenshot 2024-10-29 at 2 01 32 PM
Screenshot 2024-10-29 at 2 01 42 PM
Screenshot 2024-10-29 at 2 01 50 PM

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 15:15 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 19:31 Destroyed
src/lib/drupal/query.ts Outdated Show resolved Hide resolved
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 19:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 20:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 20:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 21:00 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 21:17 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 21:26 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 21:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 17, 2024 17:12 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 17, 2024 17:21 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 17, 2024 17:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 17, 2024 19:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 17, 2024 19:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2024 14:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2024 14:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2024 15:13 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2024 15:22 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2024 15:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2024 18:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 13, 2024 17:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 13, 2024 17:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 13, 2024 18:24 Destroyed
@randimays
Copy link
Contributor Author

Closing this and creating a new PR to target an integration branch instead.

@randimays randimays closed this Nov 14, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 14, 2024 16:29 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants