Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logout to revokeSessions and add revokeOtherSessions option #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itaihanski
Copy link
Member

@itaihanski itaihanski commented Nov 17, 2024

Related Issues

fixes https://github.com/descope/etc/issues/8242

Description

  • Change logout to revokeSessions and add the ability to revoke all user sessions
  • Add sign in option to revoke all other use sessions

Must

  • Tests
  • Documentation (if applicable)

@itaihanski itaihanski self-assigned this Nov 17, 2024
@itaihanski itaihanski enabled auto-merge (squash) November 17, 2024 14:02
/// Revokes the provided refresh JWT and all other active sessions for the user.
///
/// - Important: This causes all sessions for the user to be removed, and the provided
/// refresh JWT will not be usable after the logout call completes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// refresh JWT will not be usable after the logout call completes.
/// refresh JWT will not be usable after the revokeSessions call completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants