fix: angualr lazy module (#851)

## Related Issues Fixes descope/etc#8292 ## Description not allowing to load module is redundant limitation
descope · Nov 17, 2024 · 0b7b7f5 · 0b7b7f5
1 parent d705e67
commit 0b7b7f5
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 5 deletions.
diff --git a/packages/sdks/angular-sdk/.eslintrc.json b/packages/sdks/angular-sdk/.eslintrc.json
@@ -11,6 +11,7 @@
         "plugin:@angular-eslint/template/process-inline-templates"
       ],
       "rules": {
+        "no-console": 2,
         "@angular-eslint/directive-selector": [
           "error",
           {

diff --git a/packages/sdks/angular-sdk/projects/angular-sdk/src/lib/descope-auth.module.ts b/packages/sdks/angular-sdk/projects/angular-sdk/src/lib/descope-auth.module.ts
@@ -47,9 +47,8 @@ import { DescopeAuthConfig } from './types/types';
 export class DescopeAuthModule {
   constructor(@Optional() @SkipSelf() parentModule?: DescopeAuthModule) {
     if (parentModule) {
-      throw new Error(
-        'DescopeAuthModule is already loaded. Import it only once'
-      );
+      // eslint-disable-next-line no-console
+      console.log('DescopeAuthModule is loaded in a child module');
     }
   }
 

diff --git a/packages/sdks/angular-sdk/projects/angular-sdk/src/lib/services/descope-auth.service.ts b/packages/sdks/angular-sdk/projects/angular-sdk/src/lib/services/descope-auth.service.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 // workaround for TS issue https://github.com/microsoft/TypeScript/issues/42873
 // eslint-disable-next-line
 import type * as _1 from '@descope/core-js-sdk';

diff --git a/packages/sdks/angular-sdk/projects/demo-app/src/app/home/home.component.ts b/packages/sdks/angular-sdk/projects/demo-app/src/app/home/home.component.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { Component, OnInit } from '@angular/core';
 import { DescopeAuthService } from '../../../../angular-sdk/src/lib/services/descope-auth.service';
 import { Router } from '@angular/router';

diff --git a/packages/sdks/angular-sdk/projects/demo-app/src/app/login/login.component.ts b/packages/sdks/angular-sdk/projects/demo-app/src/app/login/login.component.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { Component } from '@angular/core';
 import { environment } from '../../environments/environment';
 import { Router } from '@angular/router';

diff --git a/...s/sdks/angular-sdk/projects/demo-app/src/app/my-user-profile/my-user-profile.component.ts b/...s/sdks/angular-sdk/projects/demo-app/src/app/my-user-profile/my-user-profile.component.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { Component } from '@angular/core';
 import { environment } from '../../environments/environment';
 import { Router } from '@angular/router';

diff --git a/packages/sdks/angular-sdk/projects/demo-app/src/app/protected/protected.component.ts b/packages/sdks/angular-sdk/projects/demo-app/src/app/protected/protected.component.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { Component } from '@angular/core';
 import { Router } from '@angular/router';
 import { environment } from '../../environments/environment';

diff --git a/packages/sdks/angular-sdk/projects/demo-app/src/main.ts b/packages/sdks/angular-sdk/projects/demo-app/src/main.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
 
 import { AppModule } from './app/app.module';

diff --git a/packages/sdks/react-sdk/examples/app/ManageAccessKeys.tsx b/packages/sdks/react-sdk/examples/app/ManageAccessKeys.tsx
@@ -62,12 +62,12 @@ const ManageAccessKeys = () => {
       <h2>Manage Access Keys</h2>
       <AccessKeyManagement
         widgetId="access-key-management-widget"
-        tenant={process.env.DESCOPE_TENANT_ID}
+        tenant={process.env.DESCOPE_TENANT_ID!}
       />
       <h2>Manage My Access Keys</h2>
       <AccessKeyManagement
         widgetId="user-access-key-management-widget"
-        tenant={process.env.DESCOPE_TENANT_ID}
+        tenant={process.env.DESCOPE_TENANT_ID!}
       />
     </>
   );