-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(descope-ui-mixin): use descopecdn.com #804
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 72b3871. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 😎
Lmk what you think
Also because this is a major change , if possible to make sure it doesn't break anything?
packages/libs/sdk-mixins/src/mixins/descopeUiMixin/constants.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of doing all at once
let's split it, start with applying CDN change to only 1 thing ! like widgets (less production critical)
monitor for a while , only than apply to other (more critical componants)
also, aren't you removing a fallback here ? we said to keep all existing fallbacks, and add another fallback for new domain
and we need to change domain IMO
Pull request was converted to draft
@omercnet lint fails here |
@omercnet reminder to fix lint and comments here |
@meirwah need your review too |
fixes https://github.com/descope/etc/issues/7818