Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(descope-ui-mixin): use descopecdn.com #804

Merged
merged 9 commits into from
Nov 6, 2024
Merged

feat(descope-ui-mixin): use descopecdn.com #804

merged 9 commits into from
Nov 6, 2024

Conversation

omercnet
Copy link
Member

@omercnet omercnet commented Sep 23, 2024

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:19am
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:19am
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:19am
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:19am
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:19am

Copy link

nx-cloud bot commented Sep 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 72b3871. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎

Lmk what you think

Also because this is a major change , if possible to make sure it doesn't break anything?

Copy link

@meirwah meirwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing all at once

let's split it, start with applying CDN change to only 1 thing ! like widgets (less production critical)
monitor for a while , only than apply to other (more critical componants)

also, aren't you removing a fallback here ? we said to keep all existing fallbacks, and add another fallback for new domain

and we need to change domain IMO

@omercnet omercnet marked this pull request as draft September 24, 2024 12:05
auto-merge was automatically disabled September 24, 2024 12:05

Pull request was converted to draft

@meirwah
Copy link

meirwah commented Oct 21, 2024

@omercnet lint fails here

@omercnet omercnet changed the title feat(descope-ui-mixin): use dscpcdn.net feat(descope-ui-mixin): use descopecdn.com Oct 22, 2024
@meirwah
Copy link

meirwah commented Nov 5, 2024

@omercnet reminder to fix lint and comments here

@omercnet
Copy link
Member Author

omercnet commented Nov 6, 2024

@meirwah need your review too

@meirwah
Copy link

meirwah commented Nov 6, 2024

@meirwah need your review too

in our last call, we talked about also testing manually the fallbacks
using some VPN/proxy to block and simulate

@omercnet did you do that ? after all the changes ?

@omercnet omercnet merged commit 82e2fa7 into main Nov 6, 2024
11 checks passed
@omercnet omercnet deleted the feat/dscpcdn branch November 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants