Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust decimal places #421

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Adjust decimal places #421

merged 1 commit into from
Nov 27, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Nov 18, 2023

No description provided.

@josediegorobles
Copy link
Member

It's failing in the swaps flow, could you review that?

@cryptoquick cryptoquick changed the title Ajusts decimal places in BMC Adjust decimal places Nov 19, 2023
cryptoquick
cryptoquick requested changes Nov 19, 2023
View reviewed changes
Copy link
Member

@cryptoquick cryptoquick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the wasm flow is failing a few important tests, like RGB transfers and RGB swaps. Like Jose pointed out, that might be a real issue.

That said, these are very good improvements! Will merge and deploy as soon as wasm tests look good.

@cryptoquick
Copy link
Member

@josediegorobles Looks like this is a heisenbug, see this CI run that had nothing to do with RGB code:
https://github.com/diba-io/bitmask-core/actions/runs/6917007100/job/18817683711

The one right before it ran fine:
https://github.com/diba-io/bitmask-core/actions/runs/6907609426/job/18795211121

@cryptoquick cryptoquick self-requested a review November 19, 2023 01:37
@josediegorobles
Copy link
Member

Ok, re running test is ok, but test-wasm no:

test rgb::rgb::web::transfers::create_transfer_with_fee_value ... FAIL

josediegorobles
josediegorobles approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@josediegorobles josediegorobles merged commit 9994e2d into development Nov 27, 2023
4 of 5 checks passed
@josediegorobles josediegorobles deleted the CD/decimal branch November 27, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josediegorobles josediegorobles josediegorobles approved these changes

@cryptoquick cryptoquick Awaiting requested review from cryptoquick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisdut @josediegorobles @cryptoquick