fix(serializer): support reflexive relationships

digitalsadhu · Jul 13, 2017 · 067283c · 067283c
1 parent 4fda519
commit 067283c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/lib/serializer.js b/lib/serializer.js
@@ -256,7 +256,7 @@ function parseRelations (data, relations, options) {
 
     var relationship = null
 
-    if (!_.isUndefined(fk)) {
+    if (!_.isUndefined(fk) && relation.modelTo !== relation.modelFrom) {
       if (_.isArray(fk)) {
         relationship = makeRelations(toType, fk, options)
       } else {

diff --git a/test/reflexiveRelationship.test.js b/test/reflexiveRelationship.test.js
@@ -4,9 +4,8 @@ var request = require('supertest')
 var loopback = require('loopback')
 var expect = require('chai').expect
 var JSONAPIComponent = require('../')
-var RSVP = require('rsvp')
 
-var app, Folder;
+var app, Folder
 
 describe('reflexive relationship', function () {
   beforeEach(function (done) {
@@ -42,7 +41,6 @@ describe('reflexive relationship', function () {
     JSONAPIComponent(app, { restApiRoot: '' })
   })
 
-
   it('should make initial data', function (done) {
     request(app).get('/folders').end(function (err, res) {
       expect(err).to.equal(null)
@@ -55,9 +53,9 @@ describe('reflexive relationship', function () {
     request(app).get('/folders/1/children').end(function (err, res) {
       expect(err).to.equal(null)
       expect(res.body.data.length).to.equal(2)
-      expect(res.body.data[0].relationships.children.data).to.equal(null)
-      expect(res.body.data[1].relationships.children.data).to.be.an('array')
+      expect(res.body.data[0].relationships.children.data).to.equal(undefined)
+      expect(res.body.data[1].relationships.children.data).to.equal(undefined)
       done(err)
     })
   })
-})
+})