fix Bugzilla 24745 - improve associative array syntax error message

Signed-off-by: royalpinto007 <royalpinto007@gmail.com> fix 24745 - issue line Signed-off-by: royalpinto007 <royalpinto007@gmail.com>
dlang · Sep 9, 2024 · 069ce3c · 069ce3c
1 parent 96d630c
commit 069ce3c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/compiler/src/dmd/parse.d b/compiler/src/dmd/parse.d
@@ -6791,7 +6791,7 @@ class Parser(AST, Lexer = dmd.lexer.Lexer) : Lexer
                 {
 
                     if (commaExpected)
-                        error("comma expected separating field initializers");
+                        error("incorrect syntax for associative array, expected `[]`, found `{}`");
                     const t = peek(&token);
                     Identifier id;
                     if (t.value == TOK.colon)
@@ -6822,7 +6822,7 @@ class Parser(AST, Lexer = dmd.lexer.Lexer) : Lexer
 
                 default:
                     if (commaExpected)
-                        error("comma expected separating field initializers");
+                        error("incorrect syntax for associative array, expected `[]`, found `{}`");
                     auto value = parseInitializer();
                     _is.addInit(null, value);
                     commaExpected = true;

diff --git a/compiler/test/fail_compilation/test24745.d b/compiler/test/fail_compilation/test24745.d
@@ -0,0 +1,18 @@
+// https://issues.dlang.org/show_bug.cgi?id=24745
+
+/*
+TEST_OUTPUT:
+---
+fail_compilation/test24745.d(17): Error: incorrect syntax for associative array, expected `[]`, found `{}`
+fail_compilation/test24745.d(17): Error: expression expected, not `:`
+fail_compilation/test24745.d(17): Error: incorrect syntax for associative array, expected `[]`, found `{}`
+fail_compilation/test24745.d(17): Error: incorrect syntax for associative array, expected `[]`, found `{}`
+fail_compilation/test24745.d(17): Error: expression expected, not `:`
+fail_compilation/test24745.d(17): Error: incorrect syntax for associative array, expected `[]`, found `{}`
+---
+*/
+
+void main()
+{
+    int[int] f = {1: 1, 2: 2};
+}