Add "tip" version #531
Open
Add "tip" version #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
commented
Aug 15, 2024
| {{ ) else ( -}} | ||
| # before we get too far, let's validate that our "bootstrap" Go works | ||
| export GOROOT_BOOTSTRAP=/usr/local/goroot-bootstrap; \ | ||
| # TODO figure out why QEMU's user-mode emulation with Go 1.23.0 causes "can't start telemetry child process: fork/exec /usr/local/go/bin/go: invalid argument" (it works if we run it a second time, but then later "go build" fails to fork/exec the compile process 🙃) |
There was a problem hiding this comment.
because of this "fun" with Go 1.23 + QEMU, I haven't done much testing of this on architectures other than amd64 and i386, so that's a notable blind spot that's probably worth more testing before we consider merging
tianon
commented
Aug 15, 2024
| @@ -111,8 +111,6 @@ for version; do | |||
|
|
|||
| fullVersion="$(jq -r '.[env.version].version' versions.json)" | |||
|
|
|||
| [[ "$fullVersion" == *.*[^0-9]* ]] || fullVersion+='.0' | |||
There was a problem hiding this comment.
This change is technically valid even without this PR, but it's currently harmless (however with it in this PR, we end up with tags like tip-YYYYMMDD.0, which is undesirable).
tianon
commented
Aug 15, 2024
| @@ -159,7 +242,7 @@ for version in "${versions[@]}"; do | |||
| "3.19", | |||
| empty | |||
| | "alpine" + .), | |||
| if .arches | has("windows-amd64") and .["windows-amd64"].url then | |||
| if .arches | has("windows-amd64") and .["windows-amd64"].url then # TODO consider windows + tip | |||
There was a problem hiding this comment.
It's technically very doable for us to implement Windows support, but this was enough that I didn't want to get too much deeper and decided to leave Windows as a TODO for now instead.
$ diff -u <(bashbrew cat golang) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63 2024-08-15 16:35:29.584348497 -0700
+++ /dev/fd/62 2024-08-15 16:35:29.584348497 -0700
@@ -2,6 +2,27 @@
GitRepo: https://github.com/docker-library/golang.git
Builder: buildkit
+Tags: tip-20240810-bookworm, tip-bookworm
+SharedTags: tip-20240810, tip
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/bookworm
+
+Tags: tip-20240810-bullseye, tip-bullseye
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/bullseye
+
+Tags: tip-20240810-alpine3.20, tip-alpine3.20, tip-20240810-alpine, tip-alpine
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, riscv64, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/alpine3.20
+
+Tags: tip-20240810-alpine3.19, tip-alpine3.19
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/alpine3.19
+
Tags: 1.23.0-bookworm, 1.23-bookworm, 1-bookworm, bookworm
SharedTags: 1.23.0, 1.23, 1, latest
Architectures: amd64, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x |
This is pinned to the latest commit merged upstream before midnight (UTC) on Monday of the current week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pinned to the latest commit merged upstream before midnight (UTC) on Monday of the current week (#464 (comment), https://github.com/docker-library/faq#can-i-use-a-bot-to-make-my-image-update-prs).
Closes #464
(Includes/based on #530)