Update prop types to allow for environment to be an empty object (the default)

[zmdavis]

What:

Allows for the environment type to be an empty object in both the propTypes and Typescript

Why:

The default value of environment is set to an empty object ({}) during server-side rendering (or in any environment where window is undefined), but an empty object violated the shape defined for environment in prop types. This in turn triggers a console.warn.

How:

In #1525 it was suggested to remove isRequired from all properties of environment, but this had a few downsides:

1. If environment is provided, it should be of the proper shape
2. Typescript types and prop types would diverge unless we also updated the Typescript types (which would exacerbate the first problem)

Instead, I opted to allow for environment to be an empty object in both the propTypes and Typescript typings. However, if environment is specified (and not an empty object) it will be properly typed.

Checklist:

• Documentation N/A
• Tests
• TypeScript Types
• Flow Types
• Ready to be merged
  

Fixes #1525

[silviuaavram]

Closing this in favour of #1538. That should handle the prop type issue, along with other improvements.

[silviuaavram]

@all-contributors please add @zmdavis for code, bug.

[allcontributors]

@silviuaavram

I've put up a pull request to add @zmdavis! 🎉