feat(useSelect): focus toggle on label click #1561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Focus the toggle element when the
<label>
is clicked, for useSelect.Why:
Closes #1557.
Native
<select>
works the same way with a<label>
ARIA also is on board: w3c/aria-practices#2859
How:
Add a custom
onClick
handler to useSelectgetLabelProps
that focuses the toggle element.Checklist: