Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command flag '--' for dfdaemon #185

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

karlhjm
Copy link
Contributor

@karlhjm karlhjm commented Jul 31, 2023

Description

Fix the helm template of dfdaemon, the position of command flag '--' is incorrect.

Related Issue

deploy Dragonfly in K8S with Helm but HTTP(s) Proxy of docker failed to automatically configure

Motivation and Context

Enable Docker's HTTP(s) proxy to be injected correctly and take effect.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 775fe8d into dragonflyoss:main Aug 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants