Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three additional signature algorithms, offered by atleast AWS #139

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

MathiasKoch
Copy link
Contributor

This PR adds three additional SignatureAlgorithms, that are at least offered by AWS, making it impossible to decode their extension data without them in the enum.

An alternative approach would be to silently ignore unknown signature algorithms rather than turning it into an error?

 Sha224Ecdsa = 0x0303,
 Sha224Rsa = 0x0301,
 Sha224Dsa = 0x0302,

@MathiasKoch
Copy link
Contributor Author

MathiasKoch commented Mar 15, 2024

Hmm.. Not sure that I understand why that test case is suddenly failing? It does however also fail on main, if i check that out.

EDIT: AHH.. InvalidCertificate(Expired). Did not think about that when I created it.
I will add some new long-living certificates for the tests.

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lulf lulf merged commit f788e02 into drogue-iot:main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants