Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
After starting this project it was decided the best option was to break this into smaller tasks. For this branch:
I kept track of my work on this spreadsheet.
Under the "Contents" column I marked it with a "Y" for Yes, it's been included.
Under the "Version Added" column, I highlighted it green when I added the version number and section to the file.
I DID NOT review any of Tina's s2s files. I don't know if this should be done or not.
Please open the files and make sure the data looks good. There are some light blue highlights on the above spreadsheet so you are informed of some oddities.
Here is a link to my work via the web
Here is the github area.
DO NOT close this issue when the pull request has been approved. Many more items need to be addressed before we can close this pull request.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [11/18/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases