Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2741 add version #2793

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Feature 2741 add version #2793

merged 9 commits into from
Nov 14, 2024

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Nov 14, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    After starting this project it was decided the best option was to break this into smaller tasks. For this branch:
  1. Cleaning up the first 5 lines of code to make sure they are consistent with the template. This involved changing some of the underlining, making sure the conf file and directory stayed on the same line and fixing some spacing issues.
  2. All of the Model Applications files now have a "contents" at the beginning of the file to find sections quickly.
  3. All of the Model Applications files now include a version number.
  4. This work started in the Marine and Cryosphere directory and went alphabetically by directory. (The earlier directories had been done and need a more detailed review by a scientist.)

I kept track of my work on this spreadsheet.
Under the "Contents" column I marked it with a "Y" for Yes, it's been included.
Under the "Version Added" column, I highlighted it green when I added the version number and section to the file.

I DID NOT review any of Tina's s2s files. I don't know if this should be done or not.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please open the files and make sure the data looks good. There are some light blue highlights on the above spreadsheet so you are informed of some oddities.
    Here is a link to my work via the web
    Here is the github area.

DO NOT close this issue when the pull request has been approved. Many more items need to be addressed before we can close this pull request.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [11/18/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@lisagoodrich lisagoodrich added this to the METplus-6.0.0 milestone Nov 14, 2024
@lisagoodrich lisagoodrich linked an issue Nov 14, 2024 that may be closed by this pull request
24 tasks
@jprestop jprestop modified the milestones: METplus-6.0.0, METplus-6.1.0 Nov 14, 2024
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of your work on this task @lisagoodrich. It looks great! I approve this request. I will go ahead and Squash and Merge and delete the branch, but I will leave the issue open.

@jprestop jprestop merged commit 3a22fd9 into develop Nov 14, 2024
2 checks passed
@jprestop jprestop deleted the feature-_2741_add_version branch November 14, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Documentation: Update existing use cases to use the template
2 participants