Harden _Q.push wrapper in the amzn_apstag.js shim #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apstag calls are queued onto the
window.apstag._Q
array and are thencalled when the Apstag script is ready. The shim expects each queued
call to be an array containing the API method name prefix and
arguments, e.g.
I noticed in practice however, some calls are queued differently, with a
queued call looking something like this instead:
Since the original script handles that, the shim needs to as
well. Let's try our best here, without changing too much and risking
further breakage.